-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump GATOR_VERSION to 1.17.0 from 1.16.3 #586
chore: Bump GATOR_VERSION to 1.17.0 from 1.16.3 #586
Conversation
In the 1.17.0 version of gator (which I've been using on my machine), the `--experimental-enable-k8s-native-validation` flag has been renamed to `--enable-k8s-native-validation`. This was preventing me from using the `make verify-gator` target. This PR fixes updates the GATOR_VERSION and changes the flag. Signed-off-by: juliankatz <[email protected]>
@julianKatz - Probably want to bump
|
@apeabody correct, we'll need to support both --experimental and non-experimental flags since we support 2 versions |
This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
@julianKatz Are you still working on this? |
if we wait until 3.18 is cut, we should be good with this PR after updating version to 3.18 |
@julianKatz This PR is really close! can you pls update this to 3.17.1, 3.18.0? |
8f73019
to
684a719
Compare
Signed-off-by: Andrew Peabody <[email protected]>
684a719
to
6ab6bca
Compare
Hi @ritazh - Can you please check if this is now ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the 1.17.0 version of gator (which I've been using on my machine), the
--experimental-enable-k8s-native-validation
flag has been renamed to--enable-k8s-native-validation
. This was preventing me from using themake verify-gator
target.This PR fixes updates the GATOR_VERSION and changes the flag.